Click to See Complete Forum and Search --> : My first fully CSS site! How did I do?
Compo
08-21-2006, 04:41 AM
This is my first attempt at a fully CSS built site, after "leaving" web design for about 4 years after I'd graduated with my design degree. It's a long story :)
I'm basically using a few project sites to sharpen up my skills, and learn the new standards in coding (PHP, CSS, XHTML etc). Any thoughts on the look, or the workings of the site will be gratefully received.
http://www.acecards.com
Many thanks,
Compo
orkaknos12
08-21-2006, 02:30 PM
spam?
-Jon
chris_bcn
08-21-2006, 03:03 PM
Not bad at all for a first effort
The nav shouldn't be in a table, and you've gone a bit mad on the amount of divs in there.
Good start, and a good place to build from
Noonan
08-21-2006, 03:22 PM
I'm still very much in the learning stages of applying CSS to my web design but I did notice the unneeded use of tables in the menu.
Beyond that, the code looks pretty good. Though it is a bit heavy in some spots I'm sure you, as well as myself, will continue to get better at writing cleaner code as we progress. I'll have a project to post in the next week or so for critique.
Ryan8720
08-21-2006, 11:37 PM
Not bad. Like others said, you don't need the table for the nav. You can easily use a styled list (http://css.maxdesign.com.au/listamatic/).
And like others said, you don't need all those divs. The SideBarBanner class could be applied directly to the anchor tags, eliminating the need for those extraneous divs.
Looks good...wish I could do css even that well.
Compo
08-22-2006, 07:41 AM
Yeah, you got me there. I did put the nav in a table, but only because I couldn't figure out how to make a CSS button that would work the same way, with the text positioning etc.
When you say I've put too many DIV's in there, do you mean that I've got too many seperate modules on the site? Main Area / Side Bar / Banner etc ...
Cheers for the feedback, much appreciated.
Not bad at all for a first effort
The nav shouldn't be in a table, and you've gone a bit mad on the amount of divs in there.
Good start, and a good place to build from
Compo
08-22-2006, 07:42 AM
spam?
-Jon
No thanks Jon, I prefer turkey.
Compo
08-22-2006, 07:43 AM
Beyond that, the code looks pretty good. Though it is a bit heavy in some spots I'm sure you, as well as myself, will continue to get better at writing cleaner code as we progress. I'll have a project to post in the next week or so for critique.
You got me again on the use of a table for navigation. Will look out for your project in a few weeks. I'm sure you're doing well with it :)
Compo
08-22-2006, 07:47 AM
Not bad. Like others said, you don't need the table for the nav. You can easily use a styled list (http://css.maxdesign.com.au/listamatic/).
Cool, thankyou for the link mate. I'll have a read of that and see if I can replace the table :-)
Compo
08-22-2006, 07:51 AM
Looks good...wish I could do css even that well.
If that link in your signature is your site, then you've got something to be proud of mate. I love the idea of the Little Guys Network too. I hope it proves to be profitable enterprise for for all of the members.
And on another sidenote, unrelated to your post, I just checked my web stats and acecards.com has had it's first visitor from New Zealand. How cool is that. It must be a member of this board. You know who you are :)