I need help with PHP!!! [Archive] - Graphic Design Forum

Click to See Complete Forum and Search --> : I need help with PHP!!!

christydezignz

08-22-2009, 03:43 AM

I'm doing an EASY online form that should not be that hard, but it's giving me a error:

Parse error: syntax error, unexpected $end in D:\Hosting\4691023\html\newsletprocess.php on line 55

I don't understand . . this shouldn't be that hard? Can anybody help me?? What am I doing wrong?

<?php

/* Subject and Email Variables */

$emailSubject = 'Send me the e-newsletter!';
$webMaster = 'christy@phoenixdesignandprint.com';

/* Gathering Data Variables */

$nameField = $_POST['name'];
$companynameField = $_POST['companyname'];
$emailField = $_POST['email'];

$body = <<<EOD
 <hr> 
Name: $name 
Company Name: $companyname 
Email Address: $email 
EOD;

$headers = "From: $email\r\n";
$headers .= "Content-type: text/html\r\n";
$success = mail($webMaster, $emailSubject, $body, $headers);

/* Results rendered as HTML */

$theResults = <<<EOD
<html>
<title>Thank you for subscribing to our e-newsletter!</title>

<style type="text/css">

</style>
<body>
 
 
 
Thank you for subscribing to our e-newsletter!
<a href="index.html">Click here to go back to home page</a>
</body>
</html>
EOD;
echo "$theResults";
?>

vanishdesign

08-22-2009, 04:40 AM

I have never seen this EOD thing before but apparently it's acceptable PHP.

I don't think this line should work:
$headers = "From: $email\r\n";
I've seen
$headers = "From: " . $email . "\r\n";
and
$headers = "From: {$email}\r\n";

This line is definitely not going to work:
echo "$theResults";
it should be:
echo $theResults;

Your variables you're referencing are not defined, either. You say $name and $companyname, but the names you've given them are $nameField and $companynameField.

The error unfortunately is very vague - usually it means something's not closed in the code. I would stay away from this EOD stuff and just use double quotes.

Not to mention using php for the end bit is totally pointless, you can just shut php and write it out:
<?php

/* Subject and Email Variables */

$emailSubject = 'Send me the e-newsletter!';
$webMaster = 'christy@phoenixdesignandprint.com';

/* Gathering Data Variables */

$name = $_POST['name'];
$companyname = $_POST['companyname'];
$email = $_POST['email'];

$body = <<<EOD
 <hr> 
Name: $name 
Company Name: $companyname 
Email Address: $email 
EOD;

$headers = "From: {$email}\r\n";
$headers .= "Content-type: text/html\r\n";
mail($webMaster, $emailSubject, $body, $headers);
?>
<html>
<title>Thank you for subscribing to our e-newsletter!</title>

<style type="text/css">

</style>
<body>
Thank you for subscribing to our e-newsletter!
<a href="index.html">Click here to go back to home page</a>
</body>
</html>

Can I see the HTML for the form? I think you may have just mixed up post variables.

flutterby nut

08-22-2009, 05:32 AM

the <<<EOD bit is a here doc and looks to be formatted correctly...however, the ending EOD; part cannot have any whitespace preceding it or it will throw an error...it's tricky that way...do a hard return after that tag and make sure it rests flush with the side of your code editor by the line numbers...

and ensure your variable names are the same...

08-22-2009, 06:52 AM

Each line of the body can be no longer then 70 characters.

You should get the undefined variables sorted out first though.

christydezignz

08-22-2009, 08:14 PM

Can I see the HTML for the form? I think you may have just mixed up post variables.

http://highpointehs.com/newsletter.html

08-22-2009, 11:12 PM

I'll look it over, but one thing I immediately noticed is that size has been used rather then maxlength. The size attribute is visual and does not mean the number of characters. The allowed number of characters is determined by maxlength not size. Even then its only client-side and should always be checked on the server side as well which I don't believe your doing. Doing that will also raise an issue of providing the user information about what fields are invalid and how they can fixed accordingly which also has yet to be addressed.

08-22-2009, 11:24 PM

$name = $_POST['FieldData0'];
$companyname = $_POST['FieldData1'];
$email = $_POST['FieldData2'];